Skip to content

Display conflict-free merge messages for pull requests (#15773)#15796

Merged
lunny merged 1 commit into
go-gitea:release/v1.14from
zeripath:backport-15773-v1.14
May 9, 2021
Merged

Display conflict-free merge messages for pull requests (#15773)#15796
lunny merged 1 commit into
go-gitea:release/v1.14from
zeripath:backport-15773-v1.14

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented May 8, 2021

Backport #15773

Repositories using external issue tracker tend to use numeric issues in
commits. To prevent conflicts during issue reference parsing or inside
commit hooks, this change respects these configuration and uses the !
character to refer to pull requests in merge commit messages.

For repositories using squash merges, this was already handled.

Signed-off-by: JustusBunsi 61625851+justusbunsi@users.noreply.github.com
Co-authored-by: zeripath art27@cantab.net

@zeripath zeripath added the type/enhancement An improvement of existing functionality label May 8, 2021
@zeripath zeripath added this to the 1.14.2 milestone May 8, 2021
Backport go-gitea#15773

Repositories using external issue tracker tend to use numeric issues in
commits. To prevent conflicts during issue reference parsing or inside
commit hooks, this change respects these configuration and uses the !
character to refer to pull requests in merge commit messages.

For repositories using squash merges, this was already handled.

Signed-off-by: JustusBunsi <61625851+justusbunsi@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
@zeripath zeripath force-pushed the backport-15773-v1.14 branch from 4f77c36 to 1109b6c Compare May 8, 2021 19:21
@zeripath zeripath mentioned this pull request May 8, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 8, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021
@lunny lunny merged commit 76d6184 into go-gitea:release/v1.14 May 9, 2021
@zeripath zeripath deleted the backport-15773-v1.14 branch May 9, 2021 06:18
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants